[
https://issues.apache.org/jira/browse/ARTEMIS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882926#comment-15882926
]
ASF GitHub Bot commented on ARTEMIS-996:
----------------------------------------
GitHub user jdanekrh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1045
ARTEMIS-996 Simplify what was lookupHome(path) in artemis-maven-plugi…
…n and deduplicate it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdanekrh/activemq-artemis jd_lookupHome
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1045.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1045
----
commit 9b76e6602264f14545c7241c17129c659ad7d96a
Author: Jiri Danek <[email protected]>
Date: 2017-02-24T10:31:47Z
ARTEMIS-996 Simplify what was lookupHome(path) in artemis-maven-plugin and
deduplicate it
----
> Simplify and deduplicate lookupHome(path) in artemis-maven-plugin
> -----------------------------------------------------------------
>
> Key: ARTEMIS-996
> URL: https://issues.apache.org/jira/browse/ARTEMIS-996
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.0.0
> Reporter: Jiri Danek
> Priority: Trivial
>
> ArtemisCLIPlugin.java and ArtemisCreatePlugin.java in artemis-maven-plugin
> both contain the following code
> {noformat}
> 85 Path binFolder = path.resolve("bin");
> 86
> 87 if (binFolder == null && Files.exists(binFolder,
> LinkOption.NOFOLLOW_LINKS)) {
> 88 return false;
> 89 }
> {noformat}
> Check for null is unnecessary, because Path#resolve never returns null, and
> also the condition in if does not make any sense.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
