[ https://issues.apache.org/jira/browse/AMQ-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894591#comment-15894591 ]
Gary Tully commented on AMQ-6377: --------------------------------- [~cshannon] noticed the use of String for org.apache.activemq.store.kahadb.MessageDatabase#journalDiskSyncStrategy which makes that accessor a little expensive. Any good reason for that? isEnableJournalDiskSyncs is used on every kahadb transaction store! see: https://github.com/apache/activemq/blob/d9350912984f12356e9d51b0f00b5a28f5cfa58d/activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/KahaDBTransactionStore.java#L287 > Introduce a periodic disk sync mode for KahaDB journal > ------------------------------------------------------ > > Key: AMQ-6377 > URL: https://issues.apache.org/jira/browse/AMQ-6377 > Project: ActiveMQ > Issue Type: New Feature > Components: Broker, KahaDB > Affects Versions: 5.13.4 > Reporter: Christopher L. Shannon > Assignee: Christopher L. Shannon > Fix For: 5.14.0 > > > KahaDB has two modes for journal disk syncs, either always sync for each > write or never sync. I'm proposing that we add a third option, a period disk > sync. > The intended behavior of this would be to run a task in the file appender > that would sync the file (if necessary) at some periodic interval (such as > every 500 ms, or 1 second, etc) instead of every write. The file would also > be synced on close (on file rollover or shutdown) > In my testing, syncing every 1 second has been proven to be nearly > indistinguishable performance as never disk syncing but is a safer option as > you insure that a sync is performed at least once per interval. -- This message was sent by Atlassian JIRA (v6.3.15#6346)