[
https://issues.apache.org/jira/browse/ARTEMIS-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938373#comment-15938373
]
ASF GitHub Bot commented on ARTEMIS-1058:
-----------------------------------------
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/1125
ARTEMIS-1058 Jars in web tmp dir locked on Windows
The embedded jetty web server's WebAppClassloader holds up
webapp's jar files and does not release them after close.
For that reason the web app's temp dir cannot be cleaned up
on Windows. (Other platforms like Linux doesn't prevent a
force delete of files even they are not released).
As long as this behavior exists we need to have a workaround
to let the tmp dir be cleaned up.
It is possible that we use a 'customized' classloader to replace
jetty's WebAppClassloader, in which we manually iterate every
JarFile resources and close them.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward/activemq-artemis master_jetty
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1125
----
commit 1c85570d926ce1a51a34523eadab9e1714a498f2
Author: Howard Gao <[email protected]>
Date: 2017-03-23T13:45:12Z
ARTEMIS-1058 Jars in web tmp dir locked on Windows
The embedded jetty web server's WebAppClassloader holds up
webapp's jar files and does not release them after close.
For that reason the web app's temp dir cannot be cleaned up
on Windows. (Other platforms like Linux doesn't prevent a
force delete of files even they are not released).
As long as this behavior exists we need to have a workaround
to let the tmp dir be cleaned up.
It is possible that we use a 'customized' classloader to replace
jetty's WebAppClassloader, in which we manually iterate every
JarFile resources and close them.
----
> Jars in web tmp dir locked on Windows
> -------------------------------------
>
> Key: ARTEMIS-1058
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1058
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.5.3
> Environment: Windows
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Minor
> Fix For: 2.0.0
>
>
> The embedded jetty web server's WebAppClassloader holds up webapp's jar files
> and does not release them after close. For that reason the web app's temp dir
> cannot be cleaned up on Windows. (Other platforms like Linux doesn't prevent
> a force delete of files even they are not released).
> As long as this behavior exists we need to have a workaround to let
> the tmp dir be cleaned up.
> It is possible that we use a 'customized' classloader to replace jetty's
> WebAppClassloader, in which we manually iterate every JarFile resources
> and close them.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
