[
https://issues.apache.org/jira/browse/ARTEMIS-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944161#comment-15944161
]
ASF GitHub Bot commented on ARTEMIS-1074:
-----------------------------------------
GitHub user roelens8 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1139
ARTEMIS-1074 Acceptors/Connectors now start up when configured to use SSL
and a password codec
-Updates the NettyConnector and NettyAcceptor classes to pass in the
password codec property as an argument into the
ConfigurationHelper:getPasswordProperty() method when initializing the keystore
and truststore passwords.
-When using the default password codec, passwords are required to be
encrypted. If an unencrypted password was passed into the decode method, then
an exception would get thrown that doesn't explain to user what went wrong.
Fixed this issue to throw a new Configuration exception with a message saying
the password must be encrypted when an unencrypted password is passed in.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/roelens8/activemq-artemis ARTEMIS-1074
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1139.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1139
----
commit 2713953c305bb13ced92d75948633d4f119dbd18
Author: Armand Roelens <[email protected]>
Date: 2017-03-27T21:59:02Z
ARTEMIS-1074 Acceptors/Connectors now start up when configured to use SSL
and a password codec
----
> Acceptors and Connectors that enable SSL don’t start up while using a
> password codec
> ------------------------------------------------------------------------------------
>
> Key: ARTEMIS-1074
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1074
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 1.5.3, 2.0.0
> Reporter: Armand Roelens
> Priority: Critical
> Labels: security
> Fix For: 1.5.4, 2.next
>
> Attachments: exception.png
>
>
> When configuring acceptors/connectors in the artemis.xml to use SSL and a
> password codec for password encryption (masking-password is enabled to true),
> the following exception (attached to the ticket) occurs preventing the
> acceptors/connectors from starting up.
> The getPasswordProperty() method in the ConfigurationHelper expects both the
> masking password property and the password codec property as input arguments,
> however the masking password property is being passed in place of the
> password codec property (thus being passed in twice) which will cause an
> exception to occur.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
