[
https://issues.apache.org/jira/browse/ARTEMIS-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960481#comment-15960481
]
ASF GitHub Bot commented on ARTEMIS-1089:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1183
I've a similar issue to solve
[ARTEMIS-1098](https://issues.apache.org/jira/browse/ARTEMIS-1098) but I'm
trying to understand where is the best point where put the (connection) flow
control management.
For my use case it could be:
1. "hidden" in the
[ChannelImpl::send](https://github.com/apache/activemq-artemis/blob/177480d8684fe0ecffa597878e07fb17ffcb5b8c/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java#L306)
for not batched writes (this will impact the streaming of large message AFAIK
but maybe others use cases)
2. implement a new method ChannelImpl::sendControlled (or similar) that
will perform flow controlled sends and will be called (right now) only by
[ActiveMQSessionContext::sendLargeMessageChunk](https://github.com/apache/activemq-artemis/blob/177480d8684fe0ecffa597878e07fb17ffcb5b8c/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java#L468)
to reduce the impact on other use cases
I'm not seeing (right now) other ways to do it, but I want to be consistent
to what you've done here: do you have any suggestions?
> Backup sync-up is slow when paging
> ----------------------------------
>
> Key: ARTEMIS-1089
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1089
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 1.5.4, 2.0.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Fix For: 1.5.5, 2.next
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
