[
https://issues.apache.org/jira/browse/ARTEMIS-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964015#comment-15964015
]
ASF GitHub Bot commented on ARTEMIS-1108:
-----------------------------------------
GitHub user bgutjahr opened a pull request:
https://github.com/apache/activemq-artemis/pull/1194
ARTEMIS-1108: Removed AIOFileLockManager
AIOFileLockManager doesn't work on NFS-mounted share store directories.
Since the GFS2 bug https://bugzilla.redhat.com/show_bug.cgi?id=678585 has been
fixed end of 2011, the class AIOFileLockManager is no longer needed and I have
removed it.
deleted:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/AIOFileLockNodeManager.java
modified:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
modified:
artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ColocatedActiveMQServer.java
modified:
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/FileLockTest.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bgutjahr/activemq-artemis filelockfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1194.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1194
----
commit d1d9a7764fc8e51c6453900bf4aa4654c0531def
Author: Bernd Gutjahr <[email protected]>
Date: 2017-04-11T07:47:11Z
ARTEMIS-1108: Removed AIOFileLockManager
AIOFileLockManager doesn't work on NFS-mounted share store directories.
Since the GFS2 bug https://bugzilla.redhat.com/show_bug.cgi?id=678585 has been
fixed end of 2011, the class AIOFileLockManager is no longer needed and I have
removed it.
deleted:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/AIOFileLockNodeManager.java
modified:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
modified:
artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ColocatedActiveMQServer.java
modified:
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/FileLockTest.java
----
> Shared-store with AIO fails to lock lockfile on NFS shares
> ----------------------------------------------------------
>
> Key: ARTEMIS-1108
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1108
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.5.4, 2.0.0
> Environment: Linux with NFS-mounted shared-store directory
> Reporter: Bernd Gutjahr
> Priority: Minor
>
> When we setup shared-store backup servers with the shared store path pointed
> to an NFS-mounted directory, file locking didn't work until we disabled AIO
> and used NIO instead. Although NFS is not recommended and we don't want to
> use in production, we wanted to use NFS in some test or demo setups just for
> simplicity.
> As it turned out, the reason why it doesn't work with AIO is that flock is
> used instead of lockf. According to the code comments, the class
> AIOFileLockNodeManager had been added due to a GFS2 bug,
> https://bugzilla.redhat.com/show_bug.cgi?id=678585. But that GFS2 bug has
> already been fixed more than 5 years ago, end of 2011. So I think it would be
> time to remove the flock-based workaround.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
