[
https://issues.apache.org/jira/browse/ARTEMIS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989022#comment-15989022
]
ASF GitHub Bot commented on ARTEMIS-1132:
-----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1233
ARTEMIS-1132 return suectiry errors instead of generic failed
When creating some AMQP resources (senders, receivers, etc) the broker
can return an error of 'failed' instead of the security error that is
expected in these cases. In the case of a receiver being created and
a security error happening the broker fails to send back a response
causing the client to hang waiting for an attach response.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1132
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1233.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1233
----
commit 2094e4d543b525ddd1b9f31c84ea0f253980eaab
Author: Timothy Bish <[email protected]>
Date: 2017-04-28T15:12:03Z
ARTEMIS-1132 return suectiry errors instead of generic failed
When creating some AMQP resources (senders, receivers, etc) the broker
can return an error of 'failed' instead of the security error that is
expected in these cases. In the case of a receiver being created and
a security error happening the broker fails to send back a response
causing the client to hang waiting for an attach response.
----
> Creating an AMQP resources when security is configured can hang or return
> wrong error type
> ------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-1132
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1132
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.0.0
> Reporter: Timothy Bish
> Assignee: Timothy Bish
> Fix For: 2.next
>
>
> When creating an AMQP receiver and the broker is configured with security the
> attach process can hang in the case where the queue does not exist and the
> user does not have permission to create said queue. The broker doesn't
> handle the exception thrown from the addressQuery operation and the exception
> thrown is handled incorrectly leading to no response being sent to the link
> attach request.
> In some other cases where the receiver can create the queue but not consume
> from or browse the queue etc the broker sets the wrong error condition on the
> resulting attach response 'failed' instead of sending
> "amqp:unauthorized-access". This can result in clients not seeing the
> correct error response such as in Qpid JMS where a JMSSecurityException is
> expected but instead a vague JMSException is thrown. This happens during
> the creation of Temporary Destination when a dynamic node is requested as
> well.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
