[ 
https://issues.apache.org/jira/browse/ARTEMIS-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028611#comment-16028611
 ] 

ASF GitHub Bot commented on ARTEMIS-1185:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1295#discussion_r118983050
  
    --- Diff: 
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/journal/StatJournal.java
 ---
    @@ -0,0 +1,288 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.activemq.artemis.cli.commands.tools.journal;
    +
    +import java.io.File;
    +import java.io.FileOutputStream;
    +import java.io.PrintStream;
    +import java.util.Arrays;
    +import java.util.Comparator;
    +import java.util.concurrent.TimeUnit;
    +import java.util.concurrent.atomic.AtomicLong;
    +import java.util.concurrent.locks.LockSupport;
    +
    +import io.airlift.airline.Command;
    +import io.airlift.airline.Option;
    +import org.apache.activemq.artemis.cli.commands.ActionContext;
    +import org.apache.activemq.artemis.cli.commands.Configurable;
    +import org.apache.activemq.artemis.core.config.impl.FileConfiguration;
    +import 
org.apache.activemq.artemis.core.io.buffer.counters.FlushSampleFlyweight;
    +import org.apache.activemq.artemis.core.io.buffer.counters.Profiler;
    +import org.apache.activemq.artemis.utils.collections.MulticastSample;
    +
    +@Command(name = "stat", description = "Provide performance statistics 
around the journal usage")
    --- End diff --
    
    maybe journal-stat?, stat seems a little too generic, e.g. what if other 
stat tools added for other parts?


> Inter-Process Journal Sampler Profiler + CLI command
> ----------------------------------------------------
>
>                 Key: ARTEMIS-1185
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1185
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: Broker
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Minor
>
> It provides a sampling profiler on buffered ASYNCIO/NIO based journals.
> The profiling has a minimal cost in term of CPU time for each sample (the 
> dominant costs are System.nanoTime() and a single cache line invalidation) 
> and total memory footprint (~OS page size in bytes).
> A proper CLI command activates a sampler to collect (ie CSV) the profiled 
> data, showing the precision of the sampling: data loss is not considered a 
> failure condition.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to