[
https://issues.apache.org/jira/browse/ARTEMIS-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042552#comment-16042552
]
Jiri Danek commented on ARTEMIS-1212:
-------------------------------------
I guess you are right. So, can be done with the test? 1) use actual old client,
2) delete the test, 3) modify the test to make it pass?
1) would be hard, it would have to be a separate maven module, I think
3) is possible, if I change the queue address for the receiver to
"jms.queue.testQueue", then the test passes. I am not sure if it is a good
solution....
> [extra-tests] HornetQProtocolManagerTest fails on InvalidDestinationException
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-1212
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1212
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: Jiri Danek
> Priority: Minor
> Labels: tests
>
> Test HornetQProtocolManagerTest fails with
> {noformat}
> ...
> [main] 18:02:53,338 INFO [org.apache.activemq.artemis.core.server] #*#*#
> Finished test: testLegacy2()...
> javax.jms.InvalidDestinationException: Destination testQueue does not exist
> at
> org.apache.activemq.artemis.jms.client.ActiveMQSession.createConsumer(ActiveMQSession.java:707)
> at
> org.apache.activemq.artemis.jms.client.ActiveMQSession.createConsumer(ActiveMQSession.java:372)
> at
> org.apache.activemq.artemis.jms.client.ActiveMQSession.createConsumer(ActiveMQSession.java:344)
> at
> org.apache.activemq.artemis.tests.extras.protocols.hornetq.HornetQProtocolManagerTest.testLegacy2(HornetQProtocolManagerTest.java:125)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
> at
> com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)
> at
> com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
> at
> com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> [main] 18:02:53,349 INFO [org.apache.activemq.artemis.core.server] #*#*#
> Starting test: testLegacy()...
> #test testLegacy
> ...
> {noformat}
> This can be reproduced using
> {noformat}
> mvn clean install
> faillines=$(mvn test -Ptests,extra-tests -Dtest=HornetQProtocolManagerTest
> -DfailIfNoTests=false -Drat.ignoreErrors=true -DskipStyleCheck=true | grep
> "There are test failures" -c)
> [[ $faillines == 0 ]]
> {noformat}
> Using git-bisect, the following commit was identified as cause
> {noformat}
> b1ad8f3adf51fa96069e1eccd7b87e9dff85223d is the first bad commit
> commit b1ad8f3adf51fa96069e1eccd7b87e9dff85223d
> Author: Justin Bertram <[email protected]>
> Date: Mon May 22 11:37:11 2017 -0500
> ARTEMIS-1178 backwards compatibility issues
>
> This commit has 2 changes for backwards compatibility with older
> clients:
> ...
> {noformat}
> CC [~jbertram]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
