[
https://issues.apache.org/jira/browse/ARTEMIS-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057348#comment-16057348
]
ASF GitHub Bot commented on ARTEMIS-1244:
-----------------------------------------
GitHub user michalxo opened a pull request:
https://github.com/apache/activemq-artemis/pull/1357
Artemis 607 qe
Please note, that testCheckInterceptedMQTTMessageProperties currently fails
because of issue ARTEMIS-1244 [mqtt] Retain flag of received message is
lost (caught by outgoing interceptor)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michalxo/activemq-artemis artemis-607-qe
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1357.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1357
----
commit 90359ea3dceb6da73eb816a747c6c087e2125f57
Author: Michal Tóth <[email protected]>
Date: 2017-06-21T09:37:45Z
ARTEMIS-607 New tests AMQP,MQTT,Stomp interceptor properties tests
Added tests for AMQP, MQTT and Stomp protocol for interceptors.
Tests are checking intercepted message properties.
Linked issue ARTEMIS-607
commit 8c00c752b1b5f11546e52701bfbcbc52439e83ec
Author: Michal Tóth <[email protected]>
Date: 2017-06-21T11:17:54Z
ARTEMIS-1244 Retain flag code todo comment
Identified possible bug in MQTT receive of missing retained flag.
----
> [mqtt] Retain flag of received message is lost (caught by outgoing
> interceptor)
> -------------------------------------------------------------------------------
>
> Key: ARTEMIS-1244
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1244
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: MQTT
> Affects Versions: 2.1.0
> Reporter: Michal Toth
> Priority: Minor
>
> Upstream test: testCheckInterceptedMQTTMessageProperties]
> [https://github.com/michalxo/activemq-artemis/commit/119e90c6c5bd2ae523e01368544ae3cb66987c4a#diff-d2a66663368a8238bae6dc85ccbd5a5d|org/apache/activemq/artemis/tests/integration/interceptors/MQTTInterceptorPropertiesTest.java
> Asked for PR.
> While implementing an upstream test and checking MQTT Outgoing interceptor, I
> have noticed that retain flag set to true is being lost when sending message
> out.
> However I did not manage to get information about this specific in [3.3.1.3.
> Retain|http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html#_Toc398718038].
> On the other hand I have found a sentence in
> [HiveMQ|http://www.hivemq.com/blog/mqtt-essentials-part-8-retained-messages]
> part 8 article:
> {quote}
> Also the subscribing client can identify if a received message was a retained
> message or not, because the broker sends out retained messages with the
> retained flag still set to true.
> {quote}
> So after all this might be a matter of implementation. (feature enhancement
> or rejected bug)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
