[
https://issues.apache.org/jira/browse/ARTEMIS-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057597#comment-16057597
]
ASF GitHub Bot commented on ARTEMIS-1240:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1350#discussion_r123263581
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
---
@@ -1140,7 +1140,17 @@ public void bufferReceived(final Object
connectionID, final ActiveMQBuffer buffe
RemotingConnection theConn = connection;
if (theConn != null && connectionID.equals(theConn.getID())) {
- theConn.bufferReceived(connectionID, buffer);
+ try {
+ theConn.bufferReceived(connectionID, buffer);
+ } catch (final RuntimeException e) {
+ ActiveMQClientLogger.LOGGER.disconnectOnErrorDecoding(e);
--- End diff --
thanks! 👍
> Disconnect at client side on decoding error
> -------------------------------------------
>
> Key: ARTEMIS-1240
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1240
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.5.5, 2.1.0
> Reporter: Howard Gao
> Fix For: 1.5.6, 2.2.0
>
>
> When a broken packet arrives at client side it causes decoding error.
> Currently artemis doesn't handle it properly. It should catch such errors and
> disconnect the underlying connection, logging a proper warning message
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)