[
https://issues.apache.org/jira/browse/ARTEMIS-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063365#comment-16063365
]
ASF GitHub Bot commented on ARTEMIS-1252:
-----------------------------------------
GitHub user roelens8 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1366
ARTEMIS-1252 Add service loading of password codec to obtain its
implementation from the app's root context
Adds service loading to obtain implementation of password codec. If no
service is found, the fallback is to use a class loader like before.
Refer to here for more information:
https://issues.apache.org/jira/browse/ARTEMIS-1252
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/roelens8/activemq-artemis ARTEMIS-1252
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1366.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1366
----
commit 9dcd7f36acc3e88c8831051ecb9df55f2ac29c02
Author: Armand Roelens <[email protected]>
Date: 2017-06-26T16:30:04Z
ARTEMIS-1252 Add service loading of password codec to obtain its
implementation from the app's root context
----
> Add service loading of password codec to obtain its implementation from the
> application’s root context, rather than using a class loader
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-1252
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1252
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 1.5.5, 2.1.0
> Reporter: Armand Roelens
>
> The current implementation for retrieving a custom password codec forces
> every OSGI bundle requiring the password codec (which can be every bundle
> with its own client that attempts to connect to the broker) to import the
> package containing the custom password codec.
> If the password codec is instead service loaded, none of the OSGI bundles
> need to import the package containing the password codec. That password codec
> package does need to advertise its implementation via a configuration file,
> but that change is limited to just that package.
> Add service loading of the custom password codec, and as a fallback, if no
> service is found, maintain the current implementation of using normal class
> loading.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
