[ 
https://issues.apache.org/jira/browse/ARTEMIS-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070401#comment-16070401
 ] 

ASF GitHub Bot commented on ARTEMIS-1185:
-----------------------------------------

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1295
  
    I think this could be made a bit more generic.. So I have moved the file 
creationg to MultiCastBuffer.
    
    This could be extended to other measures.. E.G. Message sending and 
consuming... etc.. etc... 
    
    So, right now the logic for missing measures is inside 
FlushSampleFlyweight.. while it should / should be at the buffer...
    
    
    
    I still think we should name this PipedBuffer.. you could create many 
pipes. .one for the journal, one for messages.. .etc.. etc...   it's a pipe of 
information.. where you can have multiple receivers...   
    
    
    if you create a chain of information (I'm calling pipe.. we can find other 
names) for messages.. it could be there... 
    
    
    Or maybe we could make this generic for not just the journal.. .and still 
have a single File.


> Inter-Process Journal Sampler Profiler + CLI command
> ----------------------------------------------------
>
>                 Key: ARTEMIS-1185
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1185
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: Broker
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Minor
>
> It provides a sampling profiler on buffered ASYNCIO/NIO based journals.
> The profiling has a minimal cost in term of CPU time for each sample (the 
> dominant costs are System.nanoTime() and a single cache line invalidation) 
> and total memory footprint (~OS page size in bytes).
> A proper CLI command activates a sampler to collect (ie CSV) the profiled 
> data, showing the precision of the sampling: data loss is not considered a 
> failure condition.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to