[
https://issues.apache.org/jira/browse/ARTEMIS-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070909#comment-16070909
]
ASF GitHub Bot commented on ARTEMIS-1269:
-----------------------------------------
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1382#discussion_r125150430
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationEndpoint.java
---
@@ -210,7 +210,18 @@ public void handlePacket(final Packet packet) {
ActiveMQServerLogger.LOGGER.errorHandlingReplicationPacket(e,
packet);
response = new
ActiveMQExceptionMessage(ActiveMQMessageBundle.BUNDLE.replicationUnhandledError(e));
}
- channel.send(response);
+
+ if (response != null) {
+ if (logger.isTraceEnabled()) {
+ logger.trace("Returning " + response);
+ }
+
+ if (response != null) {
--- End diff --
Checking "response" for null twice here?
> Replication Initial Synchronization won't finish sometimes
> ----------------------------------------------------------
>
> Key: ARTEMIS-1269
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1269
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 1.5.5, 2.1.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Fix For: 1.5.6, 2.2.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
