[
https://issues.apache.org/jira/browse/ARTEMIS-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084894#comment-16084894
]
ASF GitHub Bot commented on ARTEMIS-1283:
-----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1398
ARTEMIS-1283 Fix delay on drained response
On completion of drain the response is not flushed and the
client can wait a few seconds before another broker task
flushes the work. Flush the connection after updating the
linked as being drained. Also perform the work with the
connection lock held to prevent conccurent update of proton
state.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis drain-delay-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1398.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1398
----
commit 22b8076b714d4958589946a684225f19e055da78
Author: Timothy Bish <[email protected]>
Date: 2017-07-12T22:19:28Z
ARTEMIS-1283 Fix delay on drained response
On completion of drain the response is not flushed and the
client can wait a few seconds before another broker task
flushes the work. Flush the connection after updating the
linked as being drained. Also perform the work with the
connection lock held to prevent conccurent update of proton
state.
----
> AMQP Drain of a link encounters unexpected response delay
> ---------------------------------------------------------
>
> Key: ARTEMIS-1283
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1283
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.1.0
> Reporter: Timothy Bish
> Assignee: clebert suconic
> Fix For: 2.2.0
>
>
> When an AMQP attempts to drain a link the broker can take a inordinate amount
> of time to respond that the link is drained, especially if there's no
> messages to send. This happens because the action that attempts to force
> delivery is signaled of completion via a callback and the update to proton is
> made but no flush of the connection state is done.
> As a side not the drained call to the link is done outside the connection
> lock which is unsafe.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
