[
https://issues.apache.org/jira/browse/ARTEMIS-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092181#comment-16092181
]
ASF GitHub Bot commented on ARTEMIS-1276:
-----------------------------------------
GitHub user jdanekrh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1409
ARTEMIS-1276 avoid System.exit in tests as Surefire cannot deal with that
This change results in many more tests being run. Previously, 662 tests
were executed. Now, 1166 tests is executed. The running time has increased
from ~20 minutes to ~50 minutes.
Before
> Tests run: 662, Failures: 14, Errors: 4, Skipped: 1
After
> Tests run: 1166, Failures: 38, Errors: 1, Skipped: 2
(the second commit in the PR disables one of the erroring tests, because it
tests feature that Artemis does not implement)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdanekrh/activemq-artemis jd_fix_exit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1409.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1409
----
commit 4bf4ec552612f5001897b195d27c61e48efdb00e
Author: Jiri Danek <[email protected]>
Date: 2017-07-17T09:51:55Z
ARTEMIS-1276 avoid System.exit in tests as Surefire cannot deal with that
This change results in many more tests being run. Previously, 662 tests
were executed. Now, 1166 tests is executed. The running time has increased
from ~20 minutes to ~50 minutes.
commit 3ec9137a4656a5c7b35a469cde34ce2ab86177b8
Author: Jiri Danek <[email protected]>
Date: 2017-07-18T11:55:07Z
ARTEMIS-1276 disable MessageEvictionTest
The test is broken. It can be fixed by doing
```java
FakeTransportConnector(URI uri) {
setServer(new TransportServer {
@Override
public URI getConnectURI() {
return uri;
}
but then the test would fail because message
eviction is not supported by Artemis.
----
> [openwire-tests] Enable more OpenWire tests (from ActiveMQ 5)
> -------------------------------------------------------------
>
> Key: ARTEMIS-1276
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1276
> Project: ActiveMQ Artemis
> Issue Type: Test
> Components: OpenWire
> Affects Versions: 2.2.0
> Reporter: Jiri Danek
> Priority: Minor
>
> I've been looking into the currently disabled OpenWire tests, if there is a
> way to implement support for more of them and enable them.
> I believe I've made some progress on this front, so I'd wish to discuss
> 1) what is the endgame about these tests; do we want to eventually run them
> all, or is it expected to to ignore some?
> 2) what tests would be useful to enable now? I've been looking at them from
> the point of how easy it is to enable them, not how useful it is.
> 3) would it be ok to add mockito as a test dependency? it seems useful,
> because sometimes it is necessary to wrap something in ActiveMQ5 class, and
> doing a proxy avoids having to invoke superclass constructors (when the thing
> that needs to be implemented is a class and not an interface). Mockito is IMO
> nicer to use than using java.lang.reflect.Proxy.newProxyInstance directly.
> and propose PR based on that discussion.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
