[ 
https://issues.apache.org/jira/browse/ARTEMIS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105157#comment-16105157
 ] 

Michael Andre Pearce edited comment on ARTEMIS-1308 at 7/28/17 4:07 PM:
------------------------------------------------------------------------

I tested with AMQP client and OpenWire client, here there is not difference in 
performance between the CLIENT_ACKNOWLEDGE and AUTO_ACKNOWLEDGE with those, 
There is something going on in the Artemis core client here, especially as the 
perf is much much slower.

We can add back the session check, I'm not sure what Tim is getting at if I'm 
honest, the ClientMessage.acknowledge handles the difference between modes of 
INDIVIDUAL and CLIENT ACKNOWLEDGE, and core does seem to behave that when ack a 
message all messages are asked up to and including the message being acked when 
using core api. 

Even it might be my solution is not the fix, but there is an underlying issue 
somewhere.


was (Author: michael.andre.pearce):
I tested with AMQP client and OpenWire client, here there is not difference in 
performance between the CLIENT_ACKNOWLEDGE and AUTO_ACKNOWLEDGE with those, 
There is something going on in the Artemis core client here, especially as the 
perf is much much slower.

We can add back the session check, I'm not sure what Tim is getting at if I'm 
honest, the ClientMessage.acknowledge handles the difference between modes of 
INDIVIDUAL and normal ACKNOWLEDGE, and core does seem to behave that when ack a 
message all messages are asked up to and including the message being acked when 
using core api. 

Even it might be my solution is not the fix, but there is an underlying issue 
somewhere.

> Client Acknowledge not performant
> ---------------------------------
>
>                 Key: ARTEMIS-1308
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1308
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Michael Andre Pearce
>
> Artemis recommendation in docs is to use CLIENT_ACKNOWLEDGE instead of 
> AUTO_ACKNOWLEDGE, on perf testing it seems this is not the case.
> On checking code it seems the reason for this is because ActiveMQMessage 
> acknowledge actually calls session.commit, causing a full session commit all 
> the time.
> On checking Core API, calling message.acknowledge it seems to behave as 
> expected, as such believe this to be an issue in JMS api wrapper, that it 
> should just be delegating to the ClientMessage.acknowledge method and this is 
> the cause of the perf issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to