[ 
https://issues.apache.org/jira/browse/ARTEMIS-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108525#comment-16108525
 ] 

ASF GitHub Bot commented on ARTEMIS-1313:
-----------------------------------------

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1432

    ARTEMIS-1313 getAddresses in PostOfficeImpl does not correctly return…

    … all addresses
    
    Fix so that getAddresses uses addressInfoMap instead of the mappings so 
that addresses without queues also are returned

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1313

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1432.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1432
    
----
commit ef7c0ddc3e36df411c6a97446e79ba5ae9e9e1c2
Author: Michael Andre Pearce <[email protected]>
Date:   2017-08-01T07:39:34Z

    ARTEMIS-1313 getAddresses in PostOfficeImpl does not correctly return all 
addresses
    
    Fix so that getAddresses uses addressInfoMap instead of the mappings so 
that addresses without queues also are returned

----


> getAddresses in PostOfficeImpl does not correctly return all addresses
> ----------------------------------------------------------------------
>
>                 Key: ARTEMIS-1313
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1313
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Michael Andre Pearce
>         Attachments: Screen Shot 2017-08-01 at 08.19.25.png
>
>
> This is due to SimpleAddressManager only returns address's with bindings 
> (queues attached) as such if you have an Address with no queues this does not 
> return the address.
>    @Override
>    public Set<SimpleString> getAddresses() {
>       Set<SimpleString> addresses = new HashSet<>();
>       addresses.addAll(mappings.keySet());
>       return addresses;
>    }



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to