[ 
https://issues.apache.org/jira/browse/ARTEMIS-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115528#comment-16115528
 ] 

ASF GitHub Bot commented on ARTEMIS-1324:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1443#discussion_r131530849
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
 ---
    @@ -477,12 +484,44 @@ public final synchronized void start() throws 
Exception {
           }
        }
     
    +   @Override
    +   public CriticalAnalyzer getCriticalAnalyzer() {
    +      return this.analyzer;
    +   }
    +
        private void internalStart() throws Exception {
           if (state != SERVER_STATE.STOPPED) {
              logger.debug("Server already started!");
              return;
           }
     
    +      if (!configuration.isAnalyzeCritical()) {
    --- End diff --
    
    why not do this within object construction? 


> Critical Analysis and deadlock detection on broker
> --------------------------------------------------
>
>                 Key: ARTEMIS-1324
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1324
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: Broker
>            Reporter: clebert suconic
>            Assignee: clebert suconic
>            Priority: Critical
>             Fix For: 2.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to