[jira] [Commented] (ARTEMIS-1324) Critical Analysis and deadlock detection on broker

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ARTEMIS-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115631#comment-16115631
 ] 

ASF GitHub Bot commented on ARTEMIS-1324:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1443#discussion_r131534319
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java
 ---
    @@ -2064,6 +2072,53 @@ public Configuration 
setNetworkCheckPing6Command(String command) {
           return this;
        }
     
    +   @Override
    +   public boolean isAnalyzeCritical() {
    +      return analyzeCritical;
    +   }
    +
    +   @Override
    +   public Configuration setAnalyzeCritical(boolean analyzeCritical) {
    +      this.analyzeCritical = analyzeCritical;
    +      return this;
    +   }
    +
    +   @Override
    +   public long getAnalyzeCriticalTimeout() {
    +      return analyzeCriticalTimeout;
    +   }
    +
    +   @Override
    +   public Configuration setAnalyzeCriticalTimeout(long timeout) {
    +      this.analyzeCriticalTimeout = timeout;
    +      return this;
    +   }
    +
    +   @Override
    +   public long getAnalyzeCriticalCheckPeriod() {
    +      if (analyzeCriticalCheckPeriod == 
ActiveMQDefaultConfiguration.getAnalyzeCriticalCheckPeriod()) {
    --- End diff --
    
    I was more getting at should the defaulting logic of using the timeout if 
the value is not set live in the config parser?


> Critical Analysis and deadlock detection on broker
> --------------------------------------------------
>
>                 Key: ARTEMIS-1324
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1324
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: Broker
>            Reporter: clebert suconic
>            Assignee: clebert suconic
>            Priority: Critical
>             Fix For: 2.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)