[ 
https://issues.apache.org/jira/browse/ARTEMIS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115651#comment-16115651
 ] 

ASF GitHub Bot commented on ARTEMIS-1308:
-----------------------------------------

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1428
  
    @jbertram thanks for clarifying my incorrect assumption on how pr build 
works.
    
    Have as such took the opportunity to rebase, squash and correct the commit 
message to reflect now current solution.


> Client Acknowledge not performant
> ---------------------------------
>
>                 Key: ARTEMIS-1308
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1308
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: Michael Andre Pearce
>            Assignee: clebert suconic
>            Priority: Critical
>             Fix For: 2.3.0
>
>
> Artemis recommendation in docs is to use CLIENT_ACKNOWLEDGE instead of 
> AUTO_ACKNOWLEDGE, on perf testing it seems this is not the case.
> On checking code it seems the reason for this is because ActiveMQMessage 
> acknowledge actually calls session.commit, causing a full session commit all 
> the time.
> On checking Core API, calling message.acknowledge it seems to behave as 
> expected, as such believe this to be an issue in JMS api wrapper, that it 
> should just be delegating to the ClientMessage.acknowledge method and this is 
> the cause of the perf issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to