[
https://issues.apache.org/jira/browse/ARTEMIS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116709#comment-16116709
]
ASF GitHub Bot commented on ARTEMIS-1327:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1445#discussion_r131678949
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java
---
@@ -537,7 +540,11 @@ public void connectionDestroyed(final Object
connectionID) {
if (conn != null && !conn.connection.isSupportReconnect()) {
RemotingConnection removedConnection =
removeConnection(connectionID);
if (removedConnection != null) {
- server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin ->
plugin.afterDestroyConnection(removedConnection) : null);
+ try {
+ server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin
-> plugin.afterDestroyConnection(removedConnection) : null);
+ } catch (Exception e) {
+ throw new IllegalStateException("Error executing
afterDestroyConnection plugin method: " + e.getMessage(), e);
--- End diff --
same here.. I would just log.warn... you cannot interrupt the broker if
someone deploys a bugged interceptor.. can you?
> Support checked exceptions from ActiveMQServerPlugin
> ----------------------------------------------------
>
> Key: ARTEMIS-1327
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1327
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Fix For: 2.3.0
>
>
> After I was writing a couple custom plugins I realized it would be beneficial
> to support checked exceptions. This makes error handling simpler for plugin
> writers as they can throw various exceptions and not have to always wrap them
> in a RuntimeException. Almost every place in the broker where plugin methods
> are currently called already support handling checked Exceptions so this is
> pretty simple and mostly we just need to add a "throws Exception" to each of
> the methods in the ActiveMQServerPlugin interface and make sure the methods
> used to execute the plugin methods also support it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
