[ 
https://issues.apache.org/jira/browse/ARTEMIS-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118322#comment-16118322
 ] 

ASF GitHub Bot commented on ARTEMIS-1328:
-----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1447#discussion_r131907760
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ---
    @@ -664,7 +664,7 @@ public void addTail(final MessageReference ref, final 
boolean direct) {
                    if (intermediateMessageReferences.isEmpty() && 
messageReferences.isEmpty() && !pageIterator.hasNext() && 
!pageSubscription.isPaging()) {
                       // We must block on the executor to ensure any async 
deliveries have completed or we might get out of order
                       // deliveries
    -                  if (flushExecutor() && flushDeliveriesInTransit()) {
    +                  if (internalFlushExecutor(500, false) && 
flushDeliveriesInTransit()) {
    --- End diff --
    
    I will change this to no wait at all. 


> Delivery guard can take too long
> --------------------------------
>
>                 Key: ARTEMIS-1328
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1328
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: clebert suconic
>            Assignee: clebert suconic
>             Fix For: 2.3.0
>
>
> There is a flush on delivery guard flush.
> if it's taking too long it will block the queue for a long period.
> This needs to be a quick check or keep doing async checks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to