[
https://issues.apache.org/jira/browse/ARTEMIS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118653#comment-16118653
]
ASF GitHub Bot commented on ARTEMIS-1332:
-----------------------------------------
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1450
ARTEMIS-1332 - Always return a response to the client on session
metadata add
This will make sure that if there is an ActiveMQException thrown the
client will get notified and not hang.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1332
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1450.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1450
----
commit 2cd3d5948675ccb550a87067bffbf74f1169043d
Author: Christopher L. Shannon (cshannon) <christopher.l.shan...@gmail.com>
Date: 2017-08-08T17:09:03Z
ARTEMIS-1332 - Always return a response to the client on session
metadata add
This will make sure that if there is an ActiveMQException thrown the
client will get notified and not hang.
----
> The broker should always return a response when a client adds metadata
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-1332
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1332
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.2.0
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Fix For: 2.3.0
>
>
> When adding metadata to a session (such as when a JMS client adds a clientId)
> the client will never receive a response if there is an exception (other than
> duplicate client id) on the broker side and the client will just hang. This
> scenario could happen if a broker plugin throws an ActiveMQException during
> the beforeSessionMetadataAdded() method call. An example use case when an
> exception could be thrown is if a plugin writer wants to add extra security
> or put restrictions on a clientId name (length, type of characters, etc).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
