ASF subversion and git services commented on ARTEMIS-1308:

Commit 7b5d9f120ca74f3c22ec837dfb17ef662887721c in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=7b5d9f1 ]

ARTEMIS-1308 Removing start/endcall around commit

this issue many warning around the testsuite around MessageListeners
it's valid to call the commit from a different thread on this case.

> Client Acknowledge not performant
> ---------------------------------
>                 Key: ARTEMIS-1308
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1308
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: Michael Andre Pearce
>            Assignee: Michael Andre Pearce
>            Priority: Critical
>             Fix For: 2.3.0
> Artemis recommendation in docs is to use CLIENT_ACKNOWLEDGE instead of 
> AUTO_ACKNOWLEDGE, on perf testing it seems this is not the case.
> On checking code it seems the reason for this is because ActiveMQMessage 
> acknowledge actually calls session.commit, causing a full session commit all 
> the time.
> On checking Core API, calling message.acknowledge it seems to behave as 
> expected, as such believe this to be an issue in JMS api wrapper, that it 
> should just be delegating to the ClientMessage.acknowledge method and this is 
> the cause of the perf issue.

This message was sent by Atlassian JIRA

Reply via email to