[
https://issues.apache.org/jira/browse/ARTEMIS-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123267#comment-16123267
]
ASF GitHub Bot commented on ARTEMIS-1347:
-----------------------------------------
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1460
ARTEMIS-1347 - Pass the QueueBinding to beforeCreateConsumer
Instead of just the queue name the entire QueueBinding object is now
passed to the beforeCreateConsumer plugin method. Also cleaned up some
comments
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1347
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1460.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1460
----
commit 2b49987e1ad3373233b6cdb56ef99fd878fa9928
Author: Christopher L. Shannon (cshannon) <christopher.l.shan...@gmail.com>
Date: 2017-08-11T12:13:49Z
ARTEMIS-1347 - Pass the QueueBinding to beforeCreateConsumer
Instead of just the queue name the entire QueueBinding object is now
passed to the beforeCreateConsumer plugin method. Also cleaned up some
comments
----
> ActiveMQServerPlugin beforeCreateConsumer should have the QueueBinding as an
> argument
> -------------------------------------------------------------------------------------
>
> Key: ARTEMIS-1347
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1347
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Minor
> Fix For: 2.3.0
>
>
> It would be helpful if the beforeCreateConsumer passed in the QueueBinding
> object instead of just the queue name. This gives much more information to
> the plugin. The old method will be deprecated and eventually removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
