[jira] [Commented] (ARTEMIS-1357) TypedProperties encode/decode improvement

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ARTEMIS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135327#comment-16135327
 ] 

ASF GitHub Bot commented on ARTEMIS-1357:
-----------------------------------------

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1478
  
    @tabish121 @clebertsuconic I need to run the full test suite, but it seems 
a change with no colleteral effects.
    I've a couple of graphs showing the impact of the change:
    
    MASTER:
    
    
![image](https://user-images.githubusercontent.com/13125299/29527291-af374dbe-8698-11e7-926a-1aaabb839cf1.png)
    
    AFTER THE CHANGE:
    
    
![image](https://user-images.githubusercontent.com/13125299/29527362-ee96c2be-8698-11e7-9df2-8310ffa420b4.png)
    
    While now no resize() method is called at all, and the relative weight of 
most calls in the decode path are simply disappeared.
    
    
    



> TypedProperties encode/decode improvement
> -----------------------------------------
>
>                 Key: ARTEMIS-1357
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1357
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>
> In the TypedProperties decode path are possible several improvements:
> * avoid resizing (with rehashing) of the properties map 
> * avoid any allocation of BooleanValue and NullValue
> In the TypedProperties encode path is possible to use internal looping using 
> Java 8 lambdas:
> * to avoid the allocation of the Entries collection + iterator 
> * to increase the chance of loop unrolling during the iteration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)