[
https://issues.apache.org/jira/browse/ARTEMIS-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146571#comment-16146571
]
ASF GitHub Bot commented on ARTEMIS-1379:
-----------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1496#discussion_r135966165
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -177,9 +177,9 @@
private final ScheduledDeliveryHandler scheduledDeliveryHandler;
- private long messagesAdded;
+ private AtomicLong messagesAdded = new AtomicLong(0);
--- End diff --
To be more memory friendly where lots of queues can the long be volatile
and then use a AtomicLongFieldUpdater to safely update.
> MessagesAdded and MessagesAcknowledged queue stats are not thread-safe
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-1379
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1379
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
