[
https://issues.apache.org/jira/browse/ARTEMIS-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156867#comment-16156867
]
ASF GitHub Bot commented on ARTEMIS-1401:
-----------------------------------------
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/1518
@franz1981 I don't think its actually strictly doing that, though the code
it is calling can have that effect (see later), and the code calling the method
the above line is from is assuming the return value will be positive to
indicate action when it might not be (though I've never actually seen it be
negative; seems like you have?). The tick method its calling wasn't actually
written to be called with a nanotime derived value (but should have been given
what its doing). When I originally swapped to calling it with nanotime derived
values I convinced myself there wouldnt be effect of actual concern (just some
that would be harmless) when the value wrapped, but in looking again I think I
do see some cases it could be, need to dig further.
> Numerical overflow fix when using System::nanoTime
> --------------------------------------------------
>
> Key: ARTEMIS-1401
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1401
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
