[
https://issues.apache.org/jira/browse/ARTEMIS-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Danek updated ARTEMIS-1409:
--------------------------------
Priority: Minor (was: Major)
> FindBugs: inefficient use of keySet iterator instead of entrySet iterator
> -------------------------------------------------------------------------
>
> Key: ARTEMIS-1409
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1409
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Jiri Danek
> Priority: Minor
>
> Multiple occurrences of code like this
> {noformat}
> 1391 for (String key : props.keySet()) {
> 1392 propstr.append(key);
> 1393 propstr.append("=");
>
> CID 1419417 (#1 of 1): WMI: Inefficient Map Iterator
> (FB.WMI_WRONG_MAP_ITERATOR)
> 1. defect:
> org.apache.activemq.artemis.jms.server.impl.JMSServerManagerImpl.listPreparedTransactionDetailsAsHTML()
> makes inefficient use of keySet iterator instead of entrySet iterator.
> 1394 propstr.append(props.get(key));
> 1395 propstr.append(", ");
> 1396 }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
