[
https://issues.apache.org/jira/browse/ARTEMIS-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161799#comment-16161799
]
ASF GitHub Bot commented on ARTEMIS-1407:
-----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1528
ARTEMIS-1407 Remove unused method that performs invalid operation
Remove the unused transaction remove method as the getTransaction method
provides the remove operation and the remove method was doing an invalud
remove of wrong type from the transactions collection.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1407
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1528.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1528
----
commit 315755031ce29647548c8b5d09806ece0f61c154
Author: Timothy Bish <[email protected]>
Date: 2017-09-11T19:01:18Z
ARTEMIS-1407 Remove unused method that performs invalid operation
Remove the unused transaction remove method as the getTransaction method
provides the remove operation and the remove method was doing an invalud
remove of wrong type from the transactions collection.
----
> FindBugs: Suspicious calls to generic collection methods in
> AMQPConnectionCallback.java
> ---------------------------------------------------------------------------------------
>
> Key: ARTEMIS-1407
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1407
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP, Broker
> Affects Versions: 2.4.0
> Reporter: Jiri Danek
>
> {noformat}
> 249 public Transaction removeTransaction(Binary txid) {
> 250 XidImpl xid = newXID(txid.getArray());
>
> CID 1420682 (#1 of 1): GC: Suspicious calls to generic collection methods
> (FB.GC_UNRELATED_TYPES)
> 1. defect: org.apache.activemq.artemis.core.transaction.impl.XidImpl is
> incompatible with expected argument type org.apache.qpid.proton.amqp.Binary.
> 251 return transactions.remove(xid);
> 252 }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
