[ 
https://issues.apache.org/jira/browse/ARTEMIS-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163257#comment-16163257
 ] 

ASF GitHub Bot commented on ARTEMIS-1417:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1530#discussion_r138402896
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java
 ---
    @@ -267,25 +293,27 @@ public final SimpleString readNodeId() throws 
ActiveMQIllegalStateException, IOE
           return getNodeId();
        }
     
    -   protected FileLock tryLock(final int lockPos) throws Exception {
    +   protected FileLock tryLock(final long lockPos) throws IOException {
    --- End diff --
    
    lock is changed from int to long here, was there a need? 
    
    if so other methods such as lock should be updated, if not this should be 
reverted


> Failback not working on NFSv4
> -----------------------------
>
>                 Key: ARTEMIS-1417
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1417
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.3.0
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>             Fix For: 2.4.0
>
>
> If Artemis is using NFSv4 as shared store for its messaging journal to 
> provide HA then a write to server.lock made by one server may not be 
> propagated to the other server. This prevents failback from happening. This 
> is change in behavior in data synchronization between two NFSv4 clients was 
> observed when recently upgrading Linux platforms.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to