[
https://issues.apache.org/jira/browse/ARTEMIS-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165398#comment-16165398
]
ASF subversion and git services commented on ARTEMIS-1410:
----------------------------------------------------------
Commit 342cc83ea44205483fa33ba9375c40a860535032 in activemq-artemis's branch
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=342cc83 ]
ARTEMIS-1410 remove redundant code processing openwire destination
Remove some redundant code in the processing of the OpenWire Destination
name, both in the topic handler and in the method in general the
destination name only needs to be converted once and only one
SimpleString instance needs to be created from that which will then feed
all the places that either the String form or the SimpleString form of
the result is needed.
> Coverity: Identical code for different branches
> -----------------------------------------------
>
> Key: ARTEMIS-1410
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1410
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker, OpenWire
> Affects Versions: 2.4.0
> Reporter: Jiri Danek
> Priority: Trivial
>
> {noformat}
> CID 1410014 (#1 of 1): Identical code for different branches
> (IDENTICAL_BRANCHES)
> identical_branches: The same code is executed regardless of whether
> openwireDestination.isTemporary() is true, because the 'then' and 'else'
> branches are identical. Should one of the branches be modified, or the entire
> 'if' statement replaced?
> 103 if (openwireDestination.isTemporary()) {
> 104 address = new SimpleString(physicalName);
> 105 } else {
> 106 address = new SimpleString(physicalName);
> 107 }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
