[
https://issues.apache.org/jira/browse/ARTEMIS-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172453#comment-16172453
]
ASF GitHub Bot commented on ARTEMIS-1424:
-----------------------------------------
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1542#discussion_r139834842
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java
---
@@ -436,11 +435,11 @@ public ServerSession getCoreSession() {
public ActiveMQServer getCoreServer() {
return this.server;
}
-
+/*
--- End diff --
Why comment this out, the source control maintains history so leaving old
dead code in is not needed, you can just review the commit history to see it.
> Openwire not work with different tightEncoding options
> ------------------------------------------------------
>
> Key: ARTEMIS-1424
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1424
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: OpenWire
> Affects Versions: 2.3.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Fix For: 2.4.0
>
>
> If message senders and receivers uses different
> wireformat.tightEncodingEnabled options, broker will get marshalling problem.
> This is because when openwire messages are converted to core messages, and
> later these core messages converted to openwire messages, the broker uses a
> mashaller that comes with the connection used to carry the messages.
> For example, if a producer sents a message using option
> "wireformat.tightEncodingEnabled=false" and a receiver tries to receive it
> using 'true' for the same option, it'll never get it because the broker will
> fail to use a "tight encoding" marshaller to decode a 'loose encoded' message.
> To fix the problem, we always use 'tight encoding' for internal message
> converters.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
