[
https://issues.apache.org/jira/browse/ARTEMIS-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192058#comment-16192058
]
ASF GitHub Bot commented on ARTEMIS-1314:
-----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1573
ARTEMIS-1314 Fixing issues with JMS selectors on AMQP
Allows for JMS selectors on JMSCorrelationID as well as JMSXGroupID
and JMSXUserID along with some fixes to avoid an NPE case and fixes
to the conversion of AMQP MessageID and CorrelationID values when
doing cross protocol mappings. Adds new tests to cover more cases
of using the JMS selector with Qpid JMS and the AMQP test client.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis amqp-jms-selectors
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1573.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1573
----
commit 573429e9a8a68199c6c0346126d11e3d7ba64ca0
Author: Timothy Bish <[email protected]>
Date: 2017-10-04T12:49:07Z
ARTEMIS-1314 Fixing issues with JMS selectors on AMQP
Allows for JMS selectors on JMSCorrelationID as well as JMSXGroupID
and JMSXUserID along with some fixes to avoid an NPE case and fixes
to the conversion of AMQP MessageID and CorrelationID values when
doing cross protocol mappings. Adds new tests to cover more cases
of using the JMS selector with Qpid JMS and the AMQP test client.
----
> Using the message filter with JMSCorrelationID seems not to work
> ----------------------------------------------------------------
>
> Key: ARTEMIS-1314
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1314
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.1.0
> Environment: * RHEL 7
> * Java 8
> * Qpid JMS 0.23.0
> Reporter: Jens Reimann
> Assignee: Timothy Bish
>
> Creating a consumer with a message filter for the JMS correlation ID seems
> not to work:
> {code:java}
> consumer = session.createConsumer(destination, "JMSCorrelationID='" + id +
> "'");
> {code}
> The message consumer never receives the message. However, removing the filter
> an manually filtering does work:
> {code:java}
> if (id.equals(message.getJMSCorrelationID())) {
> // do stuff
> }
> {code}
> Also does the correlation ID show up in the list of properties:
> {code}
> JMSType => null
> JMSMessageID => ID:d20ffaba-25f4-497a-80e9-99d58101f589:2:1:1-1
> JMSExpiration => 0
> JMSRedelivered => false
> JMSTimestamp => 1501572098651
> JMSXUserID => null
> JMSXGroupSeq => 0
> JMS_AMQP_ACK_TYPE => null
> JMSDeliveryMode => PERSISTENT
> JMSPriority => 4
> JMSReplyTo => null
> JMSXGroupID => null
> JMSDestination => serviceAExternal
> JMSXDeliveryCount => 1
> JMSCorrelationID => d1c2daf6-2f2a-4641-a917-0f211e53e110
> JMSDeliveryTime => 1501572098651
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
