[
https://issues.apache.org/jira/browse/ARTEMIS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207164#comment-16207164
]
ASF GitHub Bot commented on ARTEMIS-1464:
-----------------------------------------
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1590
ARTEMIS-1464 Fix Core to AMQP conversion BytesMessage corrupts bytes
Extend test cases in MessageTypesTest to cover Core to AMQP combinations
for all JMSTypeTests
Fix ServerJMSBytesMessage to correctly return bodyLength
Fix CoreAmqpConverter to use amqp type "Data" instead of "AmqpValue" to
match the same as when BytesMessage sent by Qpid Jms
Remove unused/dead code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis
ARTEMIS-1464
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1590.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1590
----
commit ae7842df61bd189cf6dbeaa727cdc34f43b0a107
Author: Michael André Pearce <[email protected]>
Date: 2017-10-17T08:20:34Z
ARTEMIS-1464 Fix Core to AMQP conversion BytesMessage corrupts bytes
Extend test cases in MessageTypesTest to cover Core to AMQP combinations
for all JMSTypeTests
Fix ServerJMSBytesMessage to correctly return bodyLength
Fix CoreAmqpConverter to use amqp type "Data" instead of "AmqpValue" to
match the same as when BytesMessage sent by Qpid Jms
Remove unused/dead code
----
> Core to AMQP conversion BytesMessage corrupts bytes
> ---------------------------------------------------
>
> Key: ARTEMIS-1464
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1464
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.0.0, 2.1.0, 2.2.0, 2.3.0
> Reporter: Michael Andre Pearce
> Assignee: Michael Andre Pearce
> Fix For: 2.4.0
>
>
> When sending a Core JMS BytesMessage and consuming via AMQP , the byte array
> is corrupted, the sent byte[] != received byte[]
> byte length is not equal, it seems the bodybuffer length is not honoured
> during the conversion (which caters for buffer headers and other offsets)
> Also noted is that when AMQP producer the body is of AMQP type "Data" where
> as when using Core producer and the broker translates to AMQP the body
> becomes AMQP type "AmqpValue", this also seems like a miss-behaviour and
> possibly linked to the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
