[ 
https://issues.apache.org/jira/browse/AMQ-6844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209318#comment-16209318
 ] 

Christopher L. Shannon commented on AMQ-6844:
---------------------------------------------

@gaui - This is not because we are "lazy asses".  Not sure if you are aware of 
this but switching argument order would take all of 3 seconds.  While I agree 
that it would have been ideal that the argument order matches the problem is 
that if we changed it now it would break existing people's code.  Because it's 
an existing public API it can't really be changed.

> Misleading args order
> ---------------------
>
>                 Key: AMQ-6844
>                 URL: https://issues.apache.org/jira/browse/AMQ-6844
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: JMS client
>    Affects Versions: 5.15.1
>            Reporter: guai
>
> org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory: 
> public ActiveMQConnectionFactory(String url, String user, String password) 
> {...}
> org.apache.activemq.ActiveMQConnectionFactory:
> public ActiveMQConnectionFactory(String userName, String password, String 
> brokerURL) {...}
> all three are strings, url first vs url last can cause problems while 
> migrating and compiler won't even notice.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to