[
https://issues.apache.org/jira/browse/ARTEMIS-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215103#comment-16215103
]
ASF GitHub Bot commented on ARTEMIS-1475:
-----------------------------------------
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1604
[1.x] [ARTEMIS-1475] Fix NPE in ActiveMQMessageHandler#setup
* initialize ActiveMQActivationSpec#shareSubscriptions to false
* i18n of the exception thrown by ActiveMQMessageHandler if it is not
possible to create a non-shared subscriber
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1475
PR for master branch: https://github.com/apache/activemq-artemis/pull/1603
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmesnil/activemq-artemis
ARTEMIS-1475_ActiveMQMessageHandler_NPE_1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1604.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1604
----
commit 272ac714421c867e6b8962f6b5f2ec25ff09550c
Author: Jeff Mesnil <[email protected]>
Date: 2017-10-23T12:01:30Z
[ARTEMIS-1475] Fix NPE in ActiveMQMessageHandler#setup
* initialize ActiveMQActivationSpec#shareSubscriptions to false
* i18n of the exception thrown by ActiveMQMessageHandler if it is not
possible to create a non-shared subscriber
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1475
----
> NPE when deploying 2 MDBs with same clientID/subscriptionName
> -------------------------------------------------------------
>
> Key: ARTEMIS-1475
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1475
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.5.5
> Reporter: Jeff Mesnil
>
> Steps to reproduce:
> * deploy an application in an app server using the Artemis Resource adapters
> with 2 MDBs that have the same clientID and subscriptionName activation
> config properties:
> {code}
> @MessageDriven(name = "HelloWorldQTopicMDB2", activationConfig = {
> @ActivationConfigProperty(propertyName = "destinationLookup",
> propertyValue = "topic/HELLOWORLDMDBTopic"),
> @ActivationConfigProperty(propertyName = "destinationType",
> propertyValue = "javax.jms.Topic"),
> @ActivationConfigProperty(propertyName = "subscriptionName",
> propertyValue = "mySubscription"),
> @ActivationConfigProperty(propertyName = "clientID", propertyValue =
> "myClientId"),
> @ActivationConfigProperty(propertyName = "subscriptionDurability",
> propertyValue = "Durable"),
> @ActivationConfigProperty(propertyName = "acknowledgeMode",
> propertyValue = "Auto-acknowledge")})
> {code}
> Result:
> * when the application is deployed, it fails with the error:
> {code}
> 13:38:40,187 ERROR [org.apache.activemq.artemis.ra] (default-threads - 3)
> AMQ154003: Unable to reconnect
> org.apache.activemq.artemis.ra.inflow.ActiveMQActivatio
> nSpec(ra=org.wildfly.extension.messaging.activemq.ActiveMQResourceAdapter@2bd07716
> destination=topic/HELLOWORLDMDBTopic destinationType=javax.jms.Topic ack=Auto
> -acknowledge durable=true clientID=myClientId subscription=mySubscription
> user=null maxSession=15): java.lang.NullPointerException
> at
> org.apache.activemq.artemis.ra.inflow.ActiveMQMessageHandler.setup(ActiveMQMessageHandler.java:125)
> at
> org.apache.activemq.artemis.ra.inflow.ActiveMQActivation.setup(ActiveMQActivation.java:314)
> at
> org.apache.activemq.artemis.ra.inflow.ActiveMQActivation.reconnect(ActiveMQActivation.java:658)
> at
> org.apache.activemq.artemis.ra.inflow.ActiveMQActivation$SetupActivation.run(ActiveMQActivation.java:698)
> {code}
> Expected outcome:
> The deployment should fail with the correct exception from throw new
> javax.jms.IllegalStateException("Cannot create a subscriber on the durable
> subscription since it already has subscriber(s)");
>
> The NPE is caused by ActiveMQActivationSpec#shareSubscriptions that is not
> instantiated to false in the default constructor.
> In addition, the error message should be i18nized.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
