[
https://issues.apache.org/jira/browse/ARTEMIS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215608#comment-16215608
]
ASF GitHub Bot commented on ARTEMIS-1476:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1605#discussion_r146354093
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java
---
@@ -193,18 +291,29 @@ private static SequentialFileFactory newFactory(File
datafolder, boolean datasyn
case NIO:
factory = new NIOSequentialFileFactory(datafolder,
1).setDatasync(datasync);
- ((NIOSequentialFileFactory) factory).disableBufferReuse();
+ if (bufferReuse) {
+ ((NIOSequentialFileFactory) factory).enableBufferReuse();
--- End diff --
This is also wrong... you are changing the semantic of this test...
We are measuring how much write the system can do... Using the buffer will
defeat the purpose of the test...
Besides you are using the timeouts from where? this is not the intention of
this calculation.
> HdrHistogram support on verbose SyncCalculation
> -----------------------------------------------
>
> Key: ARTEMIS-1476
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1476
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
>
> The SyncCalculation::syncTest could benefit of
> [HdrHistogram|http://hdrhistogram.org/] support to represent the write
> latencies percentile distribution while using it as a CLI command (ie through
> the perf-journal command).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
