[
https://issues.apache.org/jira/browse/ARTEMIS-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327491#comment-16327491
]
ASF GitHub Bot commented on ARTEMIS-1610:
-----------------------------------------
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1780
ARTEMIS-1610 - Properly remove an address from the WildcardAddressManager
When an address is removed from the address manager its linked addresses
also need to be removed if there are no more bindings for the address
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1610
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1780.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1780
----
commit e27e1fa4422d128e8c7b2675d07d61da7b7dcac0
Author: Christopher L. Shannon (cshannon) <christopher.l.shannon@...>
Date: 2018-01-16T18:03:38Z
ARTEMIS-1610 - Properly remove an address from the
WildcardAddressManager
When an address is removed from the address manager its linked addresses
also need to be removed if there are no more bindings for the address
----
> NPE inside WildcardAddressManager on consumer creation
> ------------------------------------------------------
>
> Key: ARTEMIS-1610
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1610
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Major
> Fix For: 2.5.0
>
> Attachments: NPEWildcardAddressManagerTest.java
>
>
> While doing some testing with Artemis I started seeing a NPE when creating a
> consumer in certain cases. The issue occurs when there are wildcard addresses
> being registered/un-registered inside of the WildcardAddressManager before
> the creation and those addresses are linked with other addresses. This is
> causing the NPE inside the addBinding() method because it's trying to
> reference bindings that do not exist and there is no null check. I'm not sure
> the exact fix for this yet but I have a basic Junit test the shows the issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
