[
https://issues.apache.org/jira/browse/ARTEMIS-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329118#comment-16329118
]
ASF GitHub Bot commented on ARTEMIS-1587:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1775#discussion_r162131538
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionBindingQueryResponseMessage_V2.java
---
@@ -25,16 +25,21 @@
protected boolean autoCreateQueues;
+ protected boolean autoCreateQueuesDurable;
--- End diff --
Why you are adding this if this is not being written anywhere?
Also... this change is wrong.. you would need a _V5 with the new field
being written...
But honestly... there has been so any versions on
SessionBindingQueryResponse... can you add a V5 with a hashMap for new fields?
in the future we would just add more metadata instead of changing the packet.
> Add setting to control the queue durable property for auto-created addresses
> ----------------------------------------------------------------------------
>
> Key: ARTEMIS-1587
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1587
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Johan Stenberg
> Assignee: Martyn Taylor
> Priority: Major
>
> When pre-defining queues in the broker.xml the durable property can be
> specified. Auto-created queues are currently always durable. It would be
> useful to extend the AddressSettings so that default queue durability for
> auto-created queues can be specified.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
