[
https://issues.apache.org/jira/browse/ARTEMIS-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329203#comment-16329203
]
ASF GitHub Bot commented on ARTEMIS-1600:
-----------------------------------------
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1771#discussion_r162146958
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java
---
@@ -622,8 +622,8 @@ public static String getDefaultClusterPassword() {
/**
* This option controls whether passwords in server configuration need
be masked. If set to "true" the passwords are masked.
*/
- public static boolean isDefaultMaskPassword() {
- return DEFAULT_MASK_PASSWORD;
+ public static Boolean isDefaultMaskPassword() {
--- End diff --
@clebertsuconic, check out
org.apache.activemq.artemis.utils.PasswordMaskingUtil.resolveMask. I believe
the way that method works is why he needs 3 values.
> Support masked passwords in bootstrap.xm and login.config
> ---------------------------------------------------------
>
> Key: ARTEMIS-1600
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1600
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker, Web Console
> Affects Versions: 2.4.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Major
> Fix For: 2.5.0
>
>
> We provide a feature to mask passwords in the configuration files.
> However, passwords in the bootstrap.xml (when the console is
> secured with HTTPS) cannot be masked. This enhancement has
> been opened to allow passwords in the bootstrap.xml to be masked
> using the built-in masking feature provided by the broker.
> Also the LDAPLoginModule configuration (in login.config) has a
> connection password attribute that also needs this mask support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
