[
https://issues.apache.org/jira/browse/ARTEMIS-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334547#comment-16334547
]
ASF GitHub Bot commented on ARTEMIS-1623:
-----------------------------------------
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1796
Couple of things:
- Nice work!
- It's not clear to me why some things are logged at DEBUG vs. INFO.
Perhaps the documentation could address this.
- Since you're using the "f" logging method variants it's really not
necessary to do the isXEnabled() check before logging since those methods do
that check already.
- In the places where you're logging either DEBUG or INFO and the format is
the same you can use `org.jboss.logging.Logger#logf` and just pass in the level
you want to use so you don't have duplicated code.
> create an ActiveMQServerPlugin for logging various broker events
> -----------------------------------------------------------------
>
> Key: ARTEMIS-1623
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1623
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Pat Fox
> Priority: Minor
>
> create an implementation of ActiveMQServerPlugin for logging various broker
> events , consumer created, message delivered etc. This should be configurable
> to log only events user is interested in.
> Similar functionality to the ActiveMQ 5.x loggingBrokerPlugin.
> http://activemq.apache.org/logging-interceptor.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
