[
https://issues.apache.org/jira/browse/ARTEMIS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350110#comment-16350110
]
ASF GitHub Bot commented on ARTEMIS-1498:
-----------------------------------------
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165608418
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
---
@@ -576,308 +334,54 @@ private static ActiveMQMessage
toAMQMessage(MessageReference reference,
amqMsg.setExpiration(coreMessage.getExpiration());
amqMsg.setPriority(coreMessage.getPriority());
amqMsg.setTimestamp(coreMessage.getTimestamp());
-
- Long brokerInTime = (Long)
coreMessage.getObjectProperty(AMQ_MSG_BROKER_IN_TIME);
- if (brokerInTime == null) {
- brokerInTime = 0L;
- }
- amqMsg.setBrokerInTime(brokerInTime);
-
amqMsg.setCompressed(isCompressed);
- //we need check null because messages may come from other clients
- //and those amq specific attribute may not be set.
- Long arrival = (Long) coreMessage.getObjectProperty(AMQ_MSG_ARRIVAL);
- if (arrival == null) {
- //messages from other sources (like core client) may not set this
prop
- arrival = 0L;
- }
- amqMsg.setArrival(arrival);
-
- final String brokerPath = (String)
coreMessage.getObjectProperty(AMQ_MSG_BROKER_PATH);
- if (brokerPath != null && !brokerPath.isEmpty()) {
- setAMQMsgBrokerPath(amqMsg, brokerPath);
- }
-
- final String clusterPath = (String)
coreMessage.getObjectProperty(AMQ_MSG_CLUSTER);
- if (clusterPath != null && !clusterPath.isEmpty()) {
- setAMQMsgClusterPath(amqMsg, clusterPath);
- }
-
- Integer commandId = (Integer)
coreMessage.getObjectProperty(AMQ_MSG_COMMAND_ID);
- if (commandId == null) {
- commandId = -1;
- }
- amqMsg.setCommandId(commandId);
-
final SimpleString corrId = (SimpleString)
coreMessage.getObjectProperty(JMS_CORRELATION_ID_PROPERTY);
if (corrId != null) {
amqMsg.setCorrelationId(corrId.toString());
}
- final byte[] dsBytes = (byte[])
coreMessage.getObjectProperty(AMQ_MSG_DATASTRUCTURE);
- if (dsBytes != null) {
- setAMQMsgDataStructure(amqMsg, marshaller, dsBytes);
- }
- final ActiveMQDestination actualDestination =
consumer.getOpenwireDestination();
- amqMsg.setDestination(OpenWireUtil.toAMQAddress(coreMessage,
actualDestination));
-
- final Object value = coreMessage.getGroupID();
--- End diff --
It is `SimpleString` to could be used the exact type instead of `Object`
> [interop] Openwire internal headers should not be part of message properties
> ----------------------------------------------------------------------------
>
> Key: ARTEMIS-1498
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1498
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: OpenWire
> Environment: interoperability between Openwire -> AMQP/Core
> Reporter: Michal Toth
> Priority: Minor
>
> Sending an empty message from Openwire JMS client to AMQP or Core receiver
> client shows extra "internal" headers (__HDR_*) in message properties.
> They should not be there, as these are internal for broker in my opinion.
> Openwire sender
> {noformat}
> $ java -jar /var/dtests/node_data/clients/aoc7.jar sender --timeout 5
> --log-msgs interop --broker tcp://localhost:61616 --address queue_name_\$
> --count 1 --conn-username admin --conn-password admin
> {'durable': True, 'priority': 4, 'ttl': 0, 'first-acquirer': False,
> 'delivery-count': 0, 'id':
> 'dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1:1:1:1',
> 'user-id':None, 'address': 'queue_name_$', 'subject': None, 'reply-to': None,
> 'correlation-id': None, 'content-type': None, 'content-encoding': None,
> 'absolute-expiry-time': 0, 'creation-time': 1509702974798, 'group-id': None,
> 'group-sequence': 0, 'reply-to-group-id': None, 'properties': {}, 'content':
> None, 'type': None}
> {noformat}
> AMQP/Core receiver
> {noformat}
> $ java -jar /var/dtests/node_data/clients/aac1.jar receiver --timeout 5
> --log-msgs interop --broker localhost:5672 --address queue_name_\$ --count 1
> --conn-username admin --conn-password admin
> Unsupported object type org.apache.qpid.proton.amqp.Binary
> \x00\x00\x00Jn\x02\xae\x02{\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01\x00\x01
> Unsupported object type org.apache.qpid.proton.amqp.Binary
> \x00\x00\x00F{\x01+\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01
> {'durable': True, 'priority': 4, 'ttl': 0, 'first-acquirer': False,
> 'delivery-count': 0, 'id': None, 'user-id': None, 'address': 'queue_name_$',
> 'subject': None, 'reply-to': None, 'correlation-id': None, 'content-type':
> None, 'content-encoding': None, 'absolute-expiry-time': 0, 'creation-time':
> 1509702974798, 'group-id': None, 'group-sequence': 0, 'reply-to-group-id':
> None, 'properties': {'__HDR_COMMAND_ID': 5, 'JMSXDeliveryCount': 1,
> '__HDR_ARRIVAL': 0, '__HDR_MESSAGE_ID':
> \x00\x00\x00Jn\x02\xae\x02{\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01\x00\x01,
> '__HDR_GROUP_SEQUENCE': 0, '__HDR_PRODUCER_ID':
> \x00\x00\x00F{\x01+\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01,
> '__HDR_DROPPABLE': False, '__HDR_BROKER_IN_TIME': 1509702974800}, 'content':
> None}
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
