[ 
https://issues.apache.org/jira/browse/ARTEMIS-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350691#comment-16350691
 ] 

ASF GitHub Bot commented on ARTEMIS-1650:
-----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1827#discussion_r165706644
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/MessageReference.java
 ---
    @@ -38,6 +38,10 @@ public static MessageReference createReference(Message 
encode, final Queue queue
     
        Message getMessage();
     
    +   default long getMessageID() {
    --- End diff --
    
    I agree here...


> Improve paged message acknowledge
> ---------------------------------
>
>                 Key: ARTEMIS-1650
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1650
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>            Reporter: shoukun huai
>            Priority: Minor
>         Attachments: jstack.txt
>
>
> PagedMessage may be GCed before it was acknowledged. In this case, server has 
> to reload the page and hold the page cache lock, then block other consumers 
> of the same queue.
> When do acknowledge, we need at least message id, transaction id, and is 
> large message.
> We believe the three property can be added to PagedReference, so we do not 
> rely on PagedMessage when acknowledge except LargeMessage.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to