[ 
https://issues.apache.org/jira/browse/ARTEMIS-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352105#comment-16352105
 ] 

ASF GitHub Bot commented on ARTEMIS-1656:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1849#discussion_r165899196
  
    --- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
    @@ -430,24 +442,29 @@ private void callFailureListeners(final 
ActiveMQException me) {
     
        // send a WireFormatInfo to the peer
        public void sendHandshake() {
    -      WireFormatInfo info = wireFormat.getPreferedWireFormatInfo();
    +      WireFormatInfo info = inWireFormat.getPreferedWireFormatInfo();
           sendCommand(info);
        }
     
        public ConnectionState getState() {
           return state;
        }
     
    +   private static void tracePhysicalSend(Connection transportConnection, 
Command command) {
    --- End diff --
    
    dedicated log message please add to the logger class


> OpenWire scalability improvements
> ---------------------------------
>
>                 Key: ARTEMIS-1656
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1656
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Minor
>
> OpenWire is using the synchronized OpenWireFormat instance belonging to 
> OpenWireProtocolManager: it won't allow to scale with the number of 
> connections.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to