[ 
https://issues.apache.org/jira/browse/ARTEMIS-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353312#comment-16353312
 ] 

ASF GitHub Bot commented on ARTEMIS-1663:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1853#discussion_r166179369
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageSubscription.java
 ---
    @@ -161,4 +165,9 @@
         * @throws Exception
         */
        void onDeletePage(Page deletedPage) throws Exception;
    +
    +   AtomicLong getDeliveredCount();
    --- End diff --
    
    not sure would want to expose an atomic outside the object as it allows 
other code to update it unexpectedly, should probably be  primitive and the 
object should return get on the atomic.


> Add enhanced message count and size metrics for Queues
> ------------------------------------------------------
>
>                 Key: ARTEMIS-1663
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1663
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Major
>
> The purpose of this Jira is to enhance the message count metrics and to add 
> size metrics for Queues.   By size metrics I mean the encoded size of all the 
> messages (for large messages this will include body as well).  Right now we 
> track memory usage but it is also very useful to know exactly how much data 
> is pending on a Queue to be consumed.  
> The scope of this will be support for tracking the count/size of pending 
> messages, count/size of delivering messages, and count/size of scheduled 
> messages.  For each of these categories durable size metrics will be tracked 
> as well. The paging store will also support tracking of size metrics as well.
> These new metrics will be exposed through JMX to allow users to view the 
> statistics.  Also by tracking these new values it will allow for enhanced 
> features in the future (ie new flow control options)
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to