[ 
https://issues.apache.org/jira/browse/ARTEMIS-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372953#comment-16372953
 ] 

ASF GitHub Bot commented on ARTEMIS-1695:
-----------------------------------------

GitHub user cshannon opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1886

    ARTEMIS-1695 - Improve STOMP compatiblity with 5.x clients

    Also make sure on authentication error in version 1.0 a client will
    disconnect

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1695

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1886.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1886
    
----
commit e93fbf25fcf12319aa7ad07c49bbb1d7798bc681
Author: Christopher L. Shannon (cshannon) <christopher.l.shannon@...>
Date:   2018-02-22T15:28:57Z

    ARTEMIS-1695 - Improve STOMP compatiblity with 5.x clients
    
    Also make sure on authentication error in version 1.0 a client will
    disconnect

----


> Improve Stomp backwards compatibility with 5.x
> ----------------------------------------------
>
>                 Key: ARTEMIS-1695
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1695
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker, STOMP
>    Affects Versions: 2.4.0
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Major
>             Fix For: 2.5.0
>
>
> As I was testing out STOMP in Artemis vs ActiveMQ 5.x I found a few 
> improvements to make:
>  
>  # ActiveMQ 5.x uses the header named "activemq.subscriptionName" for 
> supplying a subscription name.  We should support that as well so clients 
> don't need to change their code. 
>  # Artemis doesn't create a session until the first message is published or a 
> subscription is created.  I think we should create a session on connection 
> after authentication is complete.  This is more in line with how CORE works 
> and also when 5.x creates a session for a STOMP client.  
>  # The Version 10 StompFrameHandler does not properly set the response to 
> disconnect if there is an authentication error.
>  
> Also in ActiveMQ 5.x the prefixes "/topic/" and "/queue/" are used by default 
> but this can already be configured by setting prefixes in Artemis so we don't 
> need to worry about that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to