[ 
https://issues.apache.org/jira/browse/ARTEMIS-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373837#comment-16373837
 ] 

ASF GitHub Bot commented on ARTEMIS-1696:
-----------------------------------------

Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1887#discussion_r170153460
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
 ---
    @@ -1671,7 +1671,7 @@ private void 
parseClusterConnectionConfiguration(final Element e, final Configur
        private void parseGroupingHandlerConfiguration(final Element node, 
final Configuration mainConfiguration) {
           String name = node.getAttribute("name");
           String type = getString(node, "type", null, 
Validators.NOT_NULL_OR_EMPTY);
    -      String address = getString(node, "address", null, 
Validators.NOT_NULL_OR_EMPTY);
    +      String address = getString(node, "address", "", Validators.NO_CHECK);
    --- End diff --
    
    I did that to match the change that was made for the cluster-connection 
address parsing.  See 
https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java#L1581.


> Allow empty 'address' for grouping-handler
> ------------------------------------------
>
>                 Key: ARTEMIS-1696
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1696
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>             Fix For: 2.5.0
>
>
> The {{address}} of {{grouping-handler}} should match the {{address}} of the 
> associated {{cluster-connection}}.  However, the {{address}} of 
> {{cluster-connection}} can be undefined (i.e. null or empty string) but the 
> {{address}} of {{grouping-handler}} cannot.  The most common use-case for 
> {{cluster-connection}} is to have an empty or undefined {{address}} (so that 
> all addresses will be clustered).  The {{address}} of {{grouping-handler}} 
> should support this as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to