[ 
https://issues.apache.org/jira/browse/ARTEMIS-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374187#comment-16374187
 ] 

ASF GitHub Bot commented on ARTEMIS-1664:
-----------------------------------------

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1851
  
    @wy96f Np you can pick up the master and push a new PR with the new changes 
that are more improvements/gardening than fixes.
    IMO would be interesting to:
    - drop the (completly useless) benchmark on ConcurrentLongHashMapTest
    - investigate re lazySet on capacity (probably just an Unsafe::storeFence 
would enough)
    - investigate re lazySet on size or just making it a plain field and do 
something like:
    ```
       public int size() {
          int size = 0;
          for (Section<V> s : sections) {
             //read acquire the lock state and any written size
             s.tryOptimisticRead();
             size += s.size;
          }
          return size;
       }
    ```
    - [advanced] investigate about padding to avoid false sharing between 
Section fields



> fix npe bug while getting element in the process of rehash
> ----------------------------------------------------------
>
>                 Key: ARTEMIS-1664
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1664
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: yangwei
>            Priority: Major
>             Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to